Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:st): add whether to ignore null or undefined value #1515

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sorry, something went wrong.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 25, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1515 (278b2ab) into master (923d4f4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   95.59%   95.62%   +0.02%     
==========================================
  Files         269      269              
  Lines        8409     8412       +3     
  Branches     1630     1632       +2     
==========================================
+ Hits         8039     8044       +5     
+ Misses        308      307       -1     
+ Partials       62       61       -1     
Impacted Files Coverage Δ
packages/abc/st/st.config.ts 100.00% <ø> (ø)
packages/abc/st/st-data-source.ts 100.00% <100.00%> (ø)
packages/theme/src/services/title/title.service.ts 100.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cipchk cipchk merged commit 4747bcd into master Aug 25, 2022
@cipchk cipchk deleted the issues-st-ignoreParamNull branch August 27, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants