Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix merge allowedCommonJsDependencies #1526

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Sorry, something went wrong.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 8, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1526 (f908dd4) into master (1e1c165) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   95.65%   95.59%   -0.07%     
==========================================
  Files         272      272              
  Lines        8470     8419      -51     
  Branches     1653     1653              
==========================================
- Hits         8102     8048      -54     
- Misses        307      310       +3     
  Partials       61       61              
Impacted Files Coverage Δ
packages/abc/pdf/pdf.component.ts 38.93% <0.00%> (-1.48%) ⬇️
packages/chart/gauge/gauge.component.ts 94.73% <0.00%> (-0.27%) ⬇️
packages/abc/sv/sv.component.ts 97.61% <0.00%> (-0.16%) ⬇️
packages/abc/page-header/page-header.component.ts 97.82% <0.00%> (-0.14%) ⬇️
packages/chart/water-wave/water-wave.component.ts 83.08% <0.00%> (-0.13%) ⬇️
packages/abc/qr/qr.component.ts 98.00% <0.00%> (-0.12%) ⬇️
packages/chart/pie/pie.component.ts 92.40% <0.00%> (-0.10%) ⬇️
packages/abc/ellipsis/ellipsis.component.ts 96.06% <0.00%> (-0.07%) ⬇️
packages/abc/reuse-tab/reuse-tab.component.ts 95.78% <0.00%> (-0.06%) ⬇️
packages/abc/se/se.component.ts 99.08% <0.00%> (-0.04%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cipchk cipchk merged commit c43afb8 into master Sep 8, 2022
@cipchk cipchk deleted the issues-cli-set branch September 8, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants