Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:st): fix can't close panel when showOPArea is true #1527

Merged
merged 5 commits into from
Oct 2, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1527 (a02d650) into master (b9e433d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a02d650 differs from pull request most recent head 98bb37e. Consider uploading reports for the commit 98bb37e to get more accurate results

@@           Coverage Diff           @@
##           master    #1527   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         272      272           
  Lines        8436     8443    +7     
  Branches     1655     1656    +1     
=======================================
+ Hits         8065     8072    +7     
  Misses        310      310           
  Partials       61       61           
Impacted Files Coverage Δ
packages/abc/st/st-column-source.ts 99.65% <100.00%> (ø)
packages/abc/st/st-filter.component.ts 92.30% <100.00%> (+2.83%) ⬆️
packages/abc/reuse-tab/reuse-tab.component.ts 95.78% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 8, 2022

Preview is ready!

@cipchk cipchk merged commit 7d8fbf5 into master Oct 2, 2022
@cipchk cipchk deleted the issues-2299 branch October 2, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants