Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util:other:lazy): add attriburte property #1548

Merged
merged 4 commits into from
Nov 11, 2022
Merged

feat(util:other:lazy): add attriburte property #1548

merged 4 commits into from
Nov 11, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 6, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Letiste Léo Salé
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 6, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1548 (25ee4df) into master (586277d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1548   +/-   ##
=======================================
  Coverage   95.60%   95.61%           
=======================================
  Files         272      272           
  Lines        8446     8456   +10     
  Branches     1656     1661    +5     
=======================================
+ Hits         8075     8085   +10     
  Misses        310      310           
  Partials       61       61           
Impacted Files Coverage Δ
packages/util/other/lazy.service.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aLoNeIT
Copy link
Contributor

aLoNeIT commented Nov 10, 2022

提几个建议;
1:load等3个函数参数较少,能否只是单纯增加一个参数来实现attribute设置能力,这样可以兼容而非破坏性更新
2:load方法定义应该是load(string | string[] | LazyLoadItem | LazyLoadItem[]):Promise<LazyResult[]>,这样支持单独一个js加载设置url和attribute

@cipchk
Copy link
Member Author

cipchk commented Nov 10, 2022

提几个建议; 1:load等3个函数参数较少,能否只是单纯增加一个参数来实现attribute设置能力,这样可以兼容而非破坏性更新 2:load方法定义应该是load(string | string[] | LazyLoadItem | LazyLoadItem[]):Promise<LazyResult[]>,这样支持单独一个js加载设置url和attribute

已做兼容处理,并且这是一个并不热点的接口,这种破坏性变更是可控范围。

@cipchk cipchk merged commit a197bb1 into master Nov 11, 2022
@cipchk cipchk deleted the issues-2327 branch November 11, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants