Skip to content

Commit

Permalink
feat(datepicker): use readonly arrays for inputs (#3424)
Browse files Browse the repository at this point in the history
  • Loading branch information
reduckted authored and maxokorokov committed Dec 6, 2019
1 parent 16249f4 commit 2c3f96a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/datepicker/hebrew/ngb-calendar-hebrew.ts
Expand Up @@ -64,7 +64,7 @@ export class NgbCalendarHebrew extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
const date = week[week.length - 1];
return Math.ceil(getDayNumberInHebrewYear(date) / 7);
}
Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/hijri/ngb-calendar-hijri.ts
Expand Up @@ -57,7 +57,7 @@ export abstract class NgbCalendarHijri extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/jalali/ngb-calendar-persian.ts
Expand Up @@ -41,7 +41,7 @@ export class NgbCalendarPersian extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/datepicker/ngb-calendar.ts
Expand Up @@ -75,7 +75,7 @@ export abstract class NgbCalendar {
/**
* Returns the week number for a given week.
*/
abstract getWeekNumber(week: NgbDate[], firstDayOfWeek: number): number;
abstract getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number): number;

/**
* Returns the today's date.
Expand Down Expand Up @@ -139,7 +139,7 @@ export class NgbCalendarGregorian extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down

0 comments on commit 2c3f96a

Please sign in to comment.