Skip to content

Commit

Permalink
fix(modal): add missing fields to NgbModalConfig (#3406)
Browse files Browse the repository at this point in the history
This fixes TS compilation error when a user tries to set any of these fields in a `NgbModalConfig` instance.
  • Loading branch information
gentoo90 authored and maxokorokov committed Oct 18, 2019
1 parent 2cf28f4 commit 7324083
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
21 changes: 21 additions & 0 deletions src/modal/modal-config.spec.ts
@@ -0,0 +1,21 @@
import {inject} from '@angular/core/testing';

import {NgbModalConfig} from './modal-config';

describe('NgbModalConfig', () => {

it('should have sensible default values', inject([NgbModalConfig], (config: NgbModalConfig) => {

expect(config.ariaLabelledBy).toBeUndefined();
expect(config.backdrop).toBe(true);
expect(config.backdropClass).toBeUndefined();
expect(config.beforeDismiss).toBeUndefined();
expect(config.centered).toBeUndefined();
expect(config.container).toBeUndefined();
expect(config.injector).toBeUndefined();
expect(config.keyboard).toBe(true);
expect(config.scrollable).toBeUndefined();
expect(config.size).toBeUndefined();
expect(config.windowClass).toBeUndefined();
}));
});
11 changes: 10 additions & 1 deletion src/modal/modal-config.ts
Expand Up @@ -94,7 +94,16 @@ export interface NgbModalOptions {
* @since 3.1.0
*/
@Injectable({providedIn: 'root'})
export class NgbModalConfig implements NgbModalOptions {
export class NgbModalConfig implements Required<NgbModalOptions> {
ariaLabelledBy: string;
backdrop: boolean | 'static' = true;
beforeDismiss: () => boolean | Promise<boolean>;
centered: boolean;
container: string;
injector: Injector;
keyboard = true;
scrollable: boolean;
size: 'sm' | 'lg' | 'xl';
windowClass: string;
backdropClass: string;
}

0 comments on commit 7324083

Please sign in to comment.