From dd1c35db6972e97e135c2ebb1d3e3b1ad00e7acb Mon Sep 17 00:00:00 2001 From: Max Okorokov Date: Fri, 7 Feb 2020 11:44:52 +0100 Subject: [PATCH] fix(nav): don't emit (navChange) when activeId is not set initially (#3567) Fixes #3564 --- src/nav/nav.spec.ts | 2 +- src/nav/nav.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nav/nav.spec.ts b/src/nav/nav.spec.ts index db39d37640..c8b703735d 100644 --- a/src/nav/nav.spec.ts +++ b/src/nav/nav.spec.ts @@ -200,7 +200,7 @@ describe('nav', () => { expectLinks(fixture, [true, false]); expectContents(fixture, ['content 1']); expect(activeIdChangeSpy).toHaveBeenCalledWith(1); - expect(navChangeSpy).toHaveBeenCalledWith({activeId: undefined, nextId: 1, preventDefault: jasmine.any(Function)}); + expect(navChangeSpy).toHaveBeenCalledTimes(0); }); it(`should initially select nothing, if [activeId] provided is incorrect`, () => { diff --git a/src/nav/nav.ts b/src/nav/nav.ts index adb17b2f1c..a7d5d98b6b 100644 --- a/src/nav/nav.ts +++ b/src/nav/nav.ts @@ -201,7 +201,7 @@ export class NgbNav implements AfterContentInit { if (!isDefined(this.activeId)) { const nextId = this.items.first ? this.items.first.id : null; if (nextId) { - this._updateActiveId(nextId); + this._updateActiveId(nextId, false); this._cd.detectChanges(); } }