Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups reopening on iOS on trigger element touch #3024

Closed
maxokorokov opened this issue Feb 14, 2019 · 0 comments · Fixed by #3454
Closed

Popups reopening on iOS on trigger element touch #3024

maxokorokov opened this issue Feb 14, 2019 · 0 comments · Fixed by #3454

Comments

@maxokorokov
Copy link
Member

Bug description:

Popups are closing and reopening on iOS when clicking on a trigger element for widgets with AutoClose: tooltip, datepicker, etc. This attempt to fix with a delay should be rolled back and a proper solution found.

Link to minimally-working StackBlitz that reproduces the issue:

On a demo site: https://ng-bootstrap.github.io/#/components/datepicker/examples#popup

To reproduce:

  1. click on the calendar icon → popup will open
  2. click on the calendar icon again → popup will close and reopen. It should not reopen.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.0
ng-bootstrap: 4.0.3
Bootstrap: 4.0.0

cc @divdavem as you were working on AutoClose

@maxokorokov maxokorokov added this to the 5.1.3 milestone Nov 7, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes ng-bootstrap#3446
Fixes ng-bootstrap#3437
Fixes ng-bootstrap#3412
Fixes ng-bootstrap#3192
Fixes ng-bootstrap#3145
Fixes ng-bootstrap#3024
maxokorokov added a commit that referenced this issue Nov 8, 2019
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes #3446
Fixes #3437
Fixes #3412
Fixes #3192
Fixes #3145
Fixes #3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment