Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown closes on scroll in iOS #3145

Closed
laxu opened this issue Apr 26, 2019 · 1 comment · Fixed by #3454
Closed

Dropdown closes on scroll in iOS #3145

laxu opened this issue Apr 26, 2019 · 1 comment · Fixed by #3454
Labels
component: dropdown type: bug type: mobile
Milestone
5.1.3

Comments

@laxu
Copy link

laxu commented Apr 26, 2019

Bug description:

When scrolling page in iOS, Ngbdropdown menu will close. This makes clicking items on dropdown menus that do not fit on screen impossible. Expected behavior would be keeping the menu open while scrolling and only closing it when either a menu item is selected or user clicks outside the menu. It seems that scroll event causes a click event or something.

Can be replicated even on NgBootstrap 4.1.1 examples.
@mikeekert
Copy link

@maxokorokov Are there any updates on this one?

@maxokorokov maxokorokov added this to the 5.1.3 milestone Nov 7, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13
f8672e3 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes ng-bootstrap#3446
Fixes ng-bootstrap#3437
Fixes ng-bootstrap#3412
Fixes ng-bootstrap#3192
Fixes ng-bootstrap#3145
Fixes ng-bootstrap#3024
@maxokorokov maxokorokov mentioned this issue Nov 7, 2019
Merged
maxokorokov added a commit that referenced this issue Nov 8, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13 (#3454)
c08e3b4 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes #3446
Fixes #3437
Fixes #3412
Fixes #3192
Fixes #3145
Fixes #3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dropdown type: bug type: mobile
Projects
None yet
Milestone
5.1.3
Development

Successfully merging a pull request may close this issue.

fix(autoclose): fix popup components auto closing in Safari 13 maxokorokov/ng-bootstrap
3 participants
@laxu @maxokorokov @mikeekert