Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): for editable false clear the value on input change #3267

Merged

Conversation

IAfanasov
Copy link
Contributor

  • for editable false clear the value on input change instead of on suggestions fetched

Closes #3262

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests. - I feel like for the code left there is good coverage. The code that was deleted was not covered properly
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@codecov-io
Copy link

Codecov Report

Merging #3267 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
- Coverage   90.77%   90.76%   -0.02%     
==========================================
  Files          95       95              
  Lines        2711     2707       -4     
  Branches      507      506       -1     
==========================================
- Hits         2461     2457       -4     
  Misses        190      190              
  Partials       60       60
Flag Coverage Δ
#e2e 55.22% <50%> (ø) ⬆️
#unit 87.87% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
src/typeahead/typeahead.ts 96.89% <100%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b5361...3a631ce. Read the comment docs.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please add a test for this?

@maxokorokov maxokorokov added this to the 5.1.2 milestone Oct 3, 2019
- for editable false clear the value on input change instead of on suggestions fetched

Closes ng-bootstrap#3262
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test myself. Will merge when CI is green

@maxokorokov maxokorokov merged commit 176be06 into ng-bootstrap:master Oct 4, 2019
@IAfanasov IAfanasov deleted the bug/typeahead-clear-value branch December 12, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants