fix(tabset): remove aria-expanded and use aria-selected instead #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=======================================
Coverage 90.77% 90.77%
=======================================
Files 95 95
Lines 2711 2711
Branches 507 507
=======================================
Hits 2461 2461
Misses 190 190
Partials 60 60
Continue to review full report at Codecov.
|
fbasso
approved these changes
Jul 17, 2019
constantincechina
pushed a commit
to constantincechina/ng-bootstrap
that referenced
this pull request
Aug 2, 2019
4 tasks
maxokorokov
pushed a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure you have at least performed the following:
Align tabset aria attributes to Bootstrap one (https://getbootstrap.com/docs/4.0/components/navs/#javascript-behavior)