feat(datepicker): place active day above its siblings #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is minor change that moves currently focus day within month view above its siblings to let its outline be correctly rendered. This is similar to minor stylistic corrections found in the BS: https://git.io/fjyfh Thanks!
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 95 95
Lines 2743 2743
Branches 510 510
=======================================
Hits 2493 2493
Misses 190 190
Partials 60 60
Continue to review full report at Codecov.
|
|
Nice catch! Thanks for this contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minor change that moves currently focus day within month view
above its siblings to let its outline be correctly rendered.
This is similar to minor stylistic corrections found in the BS:
https://git.io/fjyfh
The before rendering (Chrome/Mac OS):
And after the change:
Thanks!