Reselect element with focus when datepicker closes

[peterblazejewicz]

This is request for change.

When:

• user selects a value in datepicker
• user dismisses datepicker clicking outside or using ESC key
  previously select element should be probably reselected, as it's done for modal with element to focus:
  https://github.com/ng-bootstrap/ng-bootstrap/blob/master/src/modal/modal-window.ts#L68

This would allow users to quickly reselect value in the case of e.g. minor error that could be quickly corrected
.
Other reference implementation supporting this behaviour:
https://material.angular.io/components/datepicker/overview
https://clarity.design/documentation/datepicker#examples

This would be non breaking change (unless some tests rely on keyboard navigation with presumed current focus behaviour).

Thanks!

NgBootstrap: 5.1

[chumbalum]

Hi. This change breaks the usage of opening the datepicker via

<input (focus)="Datepicker.open()"/>

When the datepicker is dismissed by clicking somewhere else, the input gets focussed again and reopens the datepicker, therefore it will never close again.

@maxokorokov unless there is another way of opening the datepicker on focus, this seems to be a bug for me

[terencehonles]

Hi. This change breaks the usage of opening the datepicker via

<input (focus)="Datepicker.open()"/>

When the datepicker is dismissed by clicking somewhere else, the input gets focussed again and reopens the datepicker, therefore it will never close again.

@maxokorokov unless there is another way of opening the datepicker on focus, this seems to be a bug for me

We also stumbled across this bug

[terencehonles]

Thinking about this more I think this functionality should either be explicitly enabled:

<input ngbDatepicker [refocus]="true" />

Or focus should be manually set by the user:

<input ngbDatepicker (closed)="otherElement.focus()" />

There doesn't seem to be any way for this to play nicely with (focus)="picker.open()" which @chumbalum and @zm3d3ni (directly on the commit and copied below) mention they also are running into.

@maxokorokov why you want to refocus? We are using focus to open datepicker (https://stackblitz.com/edit/angular-phaczz) and you cannot close it anymore if you click outside datepicker.