Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip does not react on changes of tooltipClass #3335

Closed
joergplewe opened this issue Aug 22, 2019 · 2 comments · Fixed by #3380
Closed

Tooltip does not react on changes of tooltipClass #3335

joergplewe opened this issue Aug 22, 2019 · 2 comments · Fixed by #3380

Comments

@joergplewe
Copy link

Bug description:

When changing tooltipClass programatically while tooltip is open, it does not reflect the change.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-3azkna

Versions of Angular, ng-bootstrap and Bootstrap:

Angular:
8.2.3

ng-bootstrap:
5.0.0

Bootstrap:
4

@joergplewe
Copy link
Author

I found a workaround, doing a close()/open() in a setTimeout():

https://stackblitz.com/edit/angular-3azkna-rbbglf

  toggleError() {
    this.isError = !this.isError;
    setTimeout( () => {
      if ( this.tooltip.isOpen() ) {
        this.tooltip.close();
        this.tooltip.open();
      }
    }, 0);
  }

peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Sep 24, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Sep 24, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
@peterblazejewicz
Copy link
Contributor

@joergplewe
Covered by #3380

peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Sep 24, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Sep 26, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
@maxokorokov maxokorokov added this to the 5.1.2 milestone Sep 27, 2019
peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Oct 9, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Oct 9, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Oct 18, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
maxokorokov pushed a commit to peterblazejewicz/ng-bootstrap that referenced this issue Oct 21, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: ng-bootstrap#3335
maxokorokov pushed a commit that referenced this issue Oct 21, 2019
This fixes issues with custom tooltip class changes  not being applied after
tooltip creation.

Fixes: #3335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants