Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): performance issues when huge min/max dates #3357

Conversation

maxokorokov
Copy link
Member

Limits the number of years displayed in the select box to 1000 at a time.

Fixes #3338

@maxokorokov maxokorokov force-pushed the datepicker/fix/min-max-performance branch from d26a65e to 6addc94 Compare September 6, 2019 12:41
@codecov-io
Copy link

Codecov Report

Merging #3357 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3357      +/-   ##
==========================================
+ Coverage   90.88%   90.89%   +0.01%     
==========================================
  Files          95       95              
  Lines        2743     2747       +4     
  Branches      510      510              
==========================================
+ Hits         2493     2497       +4     
  Misses        190      190              
  Partials       60       60
Flag Coverage Δ
#e2e 55.07% <100%> (+0.06%) ⬆️
#unit 88.01% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/datepicker/datepicker-tools.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bc4d7...6addc94. Read the comment docs.

@maxokorokov maxokorokov merged commit 22b4ca8 into ng-bootstrap:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants