Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): added row as role #3361

Merged
merged 1 commit into from Sep 11, 2019
Merged

fix(a11y): added row as role #3361

merged 1 commit into from Sep 11, 2019

Conversation

qub1t
Copy link
Contributor

@qub1t qub1t commented Sep 10, 2019

row="columnheader" needs a parent with a role="row"

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • [] added/updated any applicable tests.
  • [] added/updated any applicable API documentation.
  • [] added/updated any applicable demos.

row="columnheader" needs a parent with a role="row"
@qub1t qub1t mentioned this pull request Sep 10, 2019
2 tasks
@codecov-io
Copy link

Codecov Report

Merging #3361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3361   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          95       95           
  Lines        2743     2743           
  Branches      510      510           
=======================================
  Hits         2493     2493           
  Misses        190      190           
  Partials       60       60
Flag Coverage Δ
#e2e 55.01% <ø> (ø) ⬆️
#unit 87.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/datepicker/datepicker-month-view.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bc4d7...b55de2b. Read the comment docs.

@benouat
Copy link
Member

benouat commented Sep 11, 2019

LGTM! 👍 will merge

@benouat benouat merged commit b16a0ca into ng-bootstrap:master Sep 11, 2019
@benouat benouat added this to the 5.1.2 milestone Sep 11, 2019
@qub1t qub1t deleted the patch-2 branch September 11, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants