fix(checkbox): remove autocomplete attribute

[peterblazejewicz]

This attribute is yet to be supported by specs.

See: https://git.io/JesTb and #3376

[codecov-io]

Codecov Report

Merging #3377 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3377   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          95       95           
  Lines        2743     2743           
  Branches      510      510           
=======================================
  Hits         2493     2493           
  Misses        190      190           
  Partials       60       60

Flag	Coverage Δ
#e2e	55.01% <ø> (ø)	⬆️
#unit	87.99% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
src/buttons/checkbox.ts	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adaf6bc...7c5c14e. Read the comment docs.

[maxokorokov]

Hey, @peterblazejewicz!

The issue is well described here → twbs/bootstrap#28623, also check their fix on JS side. If I understand correctly, with Angular we can safely remove it, you're right.

Please confirm if you agree, because reasons for this change you're stating are very different ones?

I find a test a bit synthetic, but ok :)

[peterblazejewicz]

Hey, yes, you're correct. I didn't have the context of the FF problem in mind. I can't repeat that issue on my local setup (MacOS) at the moment. I was concerned about non-standard use. I see folks from BS ditched the idea completely.
Up to you!
Thanks!

[benouat]

I checked the way they fixed it in Bootstrap twbs/bootstrap#28952
As @maxokorokov said, they needed a fix in JS that we probably don't need at all because of our usage of Angular with bindings.

I will merge.