fix(datepicker): retain focus on navigation links #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterblazejewicz
force-pushed
the
fix/2780
branch
from
46676fc
to
5969134
Compare
Codecov Report
@@ Coverage Diff @@
## master #3381 +/- ##
==========================================
+ Coverage 91.05% 91.07% +0.01%
==========================================
Files 95 95
Lines 2774 2778 +4
Branches 515 515
==========================================
+ Hits 2526 2530 +4
Misses 189 189
Partials 59 59
Continue to review full report at Codecov.
|
maxokorokov
requested changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks for this fix, @peterblazejewicz!
There is one small issue when clicking on the internal <span>.
Cheers,
Max
This fixes an issue on some clients due to browser being inconsistent on handling focus on the button clicks. After the change the navigation button within the datepicker will retain focus to allow subsequent keyboard based navigation within datepicker instance. Fixes: ng-bootstrap#2780
peterblazejewicz
force-pushed
the
fix/2780
branch
from
5969134
to
a1bd8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue on some clients due to browser being inconsistent on
handling focus on the button clicks. After the change the navigation
button within the datepicker will retain focus to allow subsequent
keyboard based navigation within datepicker instance.
Fixes: #2780
This is quite established problem and here is most recent article on the topic:
https://zellwk.com/blog/inconsistent-button-behavior/
Thanks!