fix(modal): don't close popup on ESC when closing nested components #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue for datepicker, typeahead, dropdown inside the modal. When these components are closed on ESC, modal stays open. Fixes ng-bootstrap#3358
maxokorokov
force-pushed
the
modal/fix/nested-esc-closing
branch
from
464b0f3
to
1b7dae5
Compare
Codecov Report
@@ Coverage Diff @@
## master #3384 +/- ##
==========================================
+ Coverage 90.86% 90.87% +0.01%
==========================================
Files 95 95
Lines 2748 2752 +4
Branches 511 511
==========================================
+ Hits 2497 2501 +4
Misses 190 190
Partials 61 61
Continue to review full report at Codecov.
|
|
Thanks @maxokorokov I fail to find a simpler solution for this, so LGTM :) |
|
@fbasso thanks, merging! |
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this pull request
Nov 8, 2019
This uses a combination of 'mousedown/up' events instead of 'click'. This aligns behavior with bootstrap and helps with closing modal accidentally (ex. when selecting text) Some tests had to be converted to e2e Closes ng-bootstrap#3384 Fixes ng-bootstrap#1950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue for datepicker, typeahead, dropdown inside the modal.
When these components are closed on ESC, modal stays open.
The idea is to:
keyupfor all ESC autoclose handlingkeyupcheck run after all other autoclose checksFixes #3358