chore(progressbar): allow to specify progressbar text type #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As advised on the Bootstrap documentation page when using some background variants that is advisable to change the text color accordingly, for example for readability purposes. The `textType` input property allows to achieve this, adding support for binding text types to `text-*` utility class on the progress bar. Common scenario: progress bar with 'warning' type renders a white text on the yellow background (assuming default BS). This change allows users to opt to 'dark' text type to improve the readability. ref: https://getbootstrap.com/docs/4.3/utilities/colors/#background-color
Codecov Report
@@ Coverage Diff @@
## master #3394 +/- ##
=========================================
Coverage ? 90.92%
=========================================
Files ? 95
Lines ? 2754
Branches ? 511
=========================================
Hits ? 2504
Misses ? 190
Partials ? 60
Continue to review full report at Codecov.
|
maxokorokov
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Good idea, @peterblazejewicz !
LGTM, thanks!
Marking to merge in 5.2.0
(should be feat(progressbar), but don't worry will change this when merging)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change request PR:
As advised on the Bootstrap documentation page when using some
background variants that is advisable to change the text color
accordingly, for example for readability purposes. The
textTypeinputproperty allows to achieve this, adding support for binding text types
to
text-*utility class on the progress bar.Common scenario: progress bar with 'warning' type renders a white text on
the yellow background (assuming default BS). This change allows users to opt to
'dark' text type to improve the readability.
ref:
https://getbootstrap.com/docs/4.3/utilities/colors/#background-color