Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): propagate 'popoverClass' change correctly #3420

Merged

Conversation

maxokorokov
Copy link
Member

Changing [popoverClass]="expr" while the popover is opened was not correctly propagated to the popover window

Similar to the fix for the tooltip (#3335), but for the popover.

@peterblazejewicz FYI

Changing `[popoverClass]="expr"` while the popover is opened was not correctly propagated to the popover window
@codecov-io
Copy link

Codecov Report

Merging #3420 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3420      +/-   ##
==========================================
+ Coverage   91.07%   91.08%   +<.01%     
==========================================
  Files          95       95              
  Lines        2780     2782       +2     
  Branches      516      517       +1     
==========================================
+ Hits         2532     2534       +2     
  Misses        189      189              
  Partials       59       59
Flag Coverage Δ
#e2e 55.53% <0%> (-0.04%) ⬇️
#unit 88.2% <100%> (+0.04%) ⬆️
Impacted Files Coverage Δ
src/popover/popover.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a584ad...89496e0. Read the comment docs.

Copy link
Contributor

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the shout out!

@maxokorokov maxokorokov merged commit 51bfc72 into ng-bootstrap:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants