fix(modal): keep focus trap between stack modals #3422

fbasso · 2019-10-23T09:24:50Z

fix #3392

src/modal/modal-window.ts

maxokorokov

Hey @fbasso!

Left a couple of comments.

Cheers,
Max

src/modal/modal-window.ts

e2e-app/src/app/tools.po.ts

e2e-app/src/app/modal/stack/modal-stack.e2e-spec.ts

maxokorokov · 2019-10-25T08:23:11Z

e2e-app/src/app/modal/stack/modal-stack.component.ts

+
+  openModal(content: TemplateRef<any>) { this.modalService.open(content); }
+
+  search = (text$: Observable<string>) => text$.pipe(map(() => ['one', 'two', 'three']));


please remove unused functions

e2e-app/src/app/modal/stack/modal-stack.component.ts

maxokorokov

LGTM, thanks!

fbasso force-pushed the modal-stack branch from 395d39b to 8cc237c Compare October 23, 2019 09:27

pkozlowski-opensource reviewed Oct 23, 2019

View reviewed changes

src/modal/modal-window.ts Outdated Show resolved Hide resolved

fbasso force-pushed the modal-stack branch 2 times, most recently from beba9e2 to 2d1748e Compare October 24, 2019 09:40

maxokorokov added component: modal needs: rebasing needs: review labels Oct 24, 2019

maxokorokov added this to the 5.1.3 milestone Oct 25, 2019

maxokorokov requested changes Oct 25, 2019

View reviewed changes

maxokorokov added needs: work and removed needs: review labels Oct 25, 2019

fbasso force-pushed the modal-stack branch from 2d1748e to 7491b2e Compare October 25, 2019 12:30

fix(modal): keep focus trap between stack modals

fcc0f65

fbasso force-pushed the modal-stack branch from 7491b2e to fcc0f65 Compare October 25, 2019 14:06

maxokorokov added needs: review and removed needs: rebasing needs: work labels Oct 25, 2019

maxokorokov approved these changes Oct 25, 2019

View reviewed changes

maxokorokov removed the needs: review label Oct 25, 2019

maxokorokov merged commit 5610abe into ng-bootstrap:master Oct 25, 2019

fbasso deleted the modal-stack branch October 31, 2019 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(modal): keep focus trap between stack modals #3422

fix(modal): keep focus trap between stack modals #3422

fbasso commented Oct 23, 2019

maxokorokov left a comment

maxokorokov Oct 25, 2019

maxokorokov left a comment


		openModal(content: TemplateRef<any>) { this.modalService.open(content); }

		search = (text$: Observable<string>) => text$.pipe(map(() => ['one', 'two', 'three']));

fix(modal): keep focus trap between stack modals #3422

fix(modal): keep focus trap between stack modals #3422

Conversation

fbasso commented Oct 23, 2019

maxokorokov left a comment

Choose a reason for hiding this comment

maxokorokov Oct 25, 2019

Choose a reason for hiding this comment

maxokorokov left a comment

Choose a reason for hiding this comment