Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): use readonly arrays for inputs (#2773) #3426

Merged
merged 1 commit into from Dec 6, 2019
Merged

feat(accordion): use readonly arrays for inputs (#2773) #3426

merged 1 commit into from Dec 6, 2019

Conversation

reduckted
Copy link
Contributor

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Part of #2773.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, thanks!

src/accordion/accordion.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #3426 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3426   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          96       96           
  Lines        2797     2797           
  Branches      516      516           
=======================================
  Hits         2549     2549           
  Misses        190      190           
  Partials       58       58
Flag Coverage Δ
#e2e 56.16% <100%> (ø) ⬆️
#unit 87.97% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/accordion/accordion.ts 98.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4780dc1...f6743c4. Read the comment docs.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry for the delay.

@maxokorokov maxokorokov merged commit 16249f4 into ng-bootstrap:master Dec 6, 2019
@maxokorokov maxokorokov added this to the 5.2.0 milestone Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants