Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): export NgbNavbar correctly #3432

Merged

Conversation

maxokorokov
Copy link
Member

Building with NG9 produced a warning for the forgotten export

Building with NG9 produced warning for the forgotten export
@codecov-io
Copy link

Codecov Report

Merging #3432 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
+ Coverage   91.08%   91.18%   +0.09%     
==========================================
  Files          95       95              
  Lines        2782     2813      +31     
  Branches      517      528      +11     
==========================================
+ Hits         2534     2565      +31     
  Misses        189      189              
  Partials       59       59
Flag Coverage Δ
#e2e 54.95% <ø> (-0.58%) ⬇️
#unit 88.33% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/dropdown/dropdown.module.ts 100% <ø> (ø) ⬆️
src/pagination/pagination.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64aad4...de1bb3f. Read the comment docs.

@maxokorokov maxokorokov merged commit 693bcb6 into ng-bootstrap:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants