Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngbPopover with custom content and click events does not work on iOS 13/iPhone #3437

Closed
MattHoneycutt opened this issue Oct 25, 2019 · 0 comments · Fixed by #3454
Closed

ngbPopover with custom content and click events does not work on iOS 13/iPhone #3437

MattHoneycutt opened this issue Oct 25, 2019 · 0 comments · Fixed by #3454
Labels
browser: safari component: popover type: bug type: mobile
Milestone
5.1.3

Comments

@MattHoneycutt
Copy link

MattHoneycutt commented Oct 25, 2019 •
edited

Bug description:

An ngbPopover that has custom content that includes an element with a click event does not correctly fire the event on iOS 13 [autoClose]="true".

Changing to [autoClose]="'outside'" does resolve the issue, but then it leaves the popover open until the user actually clicks outside the content again (or until you dismiss it manually).

If you need access to a device to reproduce it, you can use https://appetize.io with an iPhone 11 Pro/iOS 13.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-s2mvsa

Expected behavior:
Tapping the popover, then tapping on "click me" should display a JavaScript alert. This works on desktop, but not on iOS.

Actual behavior:
Tapping on "click me" does nothing on iOS.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 8.2.4

ng-bootstrap: 5.1.2

Bootstrap: 4.3.1
@maxokorokov maxokorokov added this to the 5.1.3 milestone Nov 7, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13
f8672e3 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes ng-bootstrap#3446
Fixes ng-bootstrap#3437
Fixes ng-bootstrap#3412
Fixes ng-bootstrap#3192
Fixes ng-bootstrap#3145
Fixes ng-bootstrap#3024
@maxokorokov maxokorokov mentioned this issue Nov 7, 2019
Merged
maxokorokov added a commit that referenced this issue Nov 8, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13 (#3454)
c08e3b4 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes #3446
Fixes #3437
Fixes #3412
Fixes #3192
Fixes #3145
Fixes #3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser: safari component: popover type: bug type: mobile
Projects
None yet
Milestone
5.1.3
Development

Successfully merging a pull request may close this issue.

fix(autoclose): fix popup components auto closing in Safari 13 maxokorokov/ng-bootstrap
3 participants
@MattHoneycutt @benouat @maxokorokov