Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal is dismissed with Esc when file dialog is open #3439

Closed
MichalJakubeczy opened this issue Oct 28, 2019 · 0 comments · Fixed by #3455
Closed

Modal is dismissed with Esc when file dialog is open #3439

MichalJakubeczy opened this issue Oct 28, 2019 · 0 comments · Fixed by #3455

Comments

@MichalJakubeczy
Copy link

MichalJakubeczy commented Oct 28, 2019

Bug description:

  1. Open a modal with file input
  2. Click Browse on file input - file dialog is open
  3. Dismiss file dialog with Esc => both file dialog (correct) and modal are dismissed (wrong)

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-tfz1e2?file=app/modal-basic.ts

Open a modal, click file dialog, hit Esc and observe wrong behavior.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular:
v8.2.4

ng-bootstrap:
v5.1.2

Bootstrap:
v4.3

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
@maxokorokov maxokorokov added this to the 5.1.3 milestone Nov 7, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
Keyboard events in modal and autoclose handling use 'keydown' instead of 'keyup'

Fixes ng-bootstrap#3439
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
Keyboard events in modal and autoclose handling use 'keydown' instead of 'keyup'

Fixes ng-bootstrap#3439
maxokorokov added a commit that referenced this issue Nov 8, 2019
Keyboard events in modal and autoclose handling use 'keydown' instead of 'keyup'

Fixes #3439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants