Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown closes and link isnt followed on mobile #3446

Closed
curieos opened this issue Nov 1, 2019 · 1 comment · Fixed by #3454
Closed

Dropdown closes and link isnt followed on mobile #3446

curieos opened this issue Nov 1, 2019 · 1 comment · Fixed by #3454
Labels
component: dropdown type: bug type: mobile
Milestone
5.1.3

Comments

@curieos
Copy link

curieos commented Nov 1, 2019

Bug description:

Dropdowns refuse to work on mobile. Whenever I tap to open a link it fails to open, instead either toggling the dropdown, or toggling the dropdown and opening the one below it. Below uses similar code to what I'm running on my end. Additionally, I notice similar behaviour on the example page https://ng-bootstrap.github.io/#/components/dropdown/examples#navbar

This is on the latest version of iOS in all browsers that I have tried. I have an iPad Pro that I can not replicate this issue on.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-uxzh7s

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 8.3.14

ng-bootstrap: 5.1.2

Bootstrap: 4.3.1
@maxokorokov maxokorokov added this to the 5.1.3 milestone Nov 7, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 7, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13
f8672e3 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes ng-bootstrap#3446
Fixes ng-bootstrap#3437
Fixes ng-bootstrap#3412
Fixes ng-bootstrap#3192
Fixes ng-bootstrap#3145
Fixes ng-bootstrap#3024
@maxokorokov maxokorokov mentioned this issue Nov 7, 2019
Merged
maxokorokov added a commit that referenced this issue Nov 8, 2019
@maxokorokov
fix(autoclose): fix popup components auto closing in Safari 13 (#3454)
c08e3b4 
Don't use touch events anymore as everything works fine with `mouseup/down`

Fixes #3446
Fixes #3437
Fixes #3412
Fixes #3192
Fixes #3145
Fixes #3024
@curieos
Copy link
Author

curieos commented Nov 8, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dropdown type: bug type: mobile
Projects
None yet
Milestone
5.1.3
Development

Successfully merging a pull request may close this issue.

fix(autoclose): fix popup components auto closing in Safari 13 maxokorokov/ng-bootstrap
2 participants
@maxokorokov @curieos