fix(autoclose): fix popup components auto closing in Safari 13 #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use touch events anymore as everything works fine with `mouseup/down` Fixes ng-bootstrap#3446 Fixes ng-bootstrap#3437 Fixes ng-bootstrap#3412 Fixes ng-bootstrap#3192 Fixes ng-bootstrap#3145 Fixes ng-bootstrap#3024
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
+ Coverage 91.1% 91.17% +0.07%
==========================================
Files 95 95
Lines 2787 2787
Branches 519 516 -3
==========================================
+ Hits 2539 2541 +2
Misses 189 189
+ Partials 59 57 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues related to popup components auto closing.
Don't use touch events anymore as everything works fine with
mouseup/downFixes #3446
Fixes #3437
Fixes #3412
Fixes #3192
Fixes #3145
Fixes #3024