fix(modal): don't close modal on ESC if file dialog is open #3455
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyboard events in modal and autoclose handling use 'keydown' instead of 'keyup' Fixes ng-bootstrap#3439
maxokorokov
force-pushed
the
modal/fix/open-file-dialog
branch
from
c3253a3
to
c615f12
Compare
Codecov Report
@@ Coverage Diff @@
## master #3455 +/- ##
======================================
Coverage 91.1% 91.1%
======================================
Files 95 95
Lines 2789 2789
Branches 520 520
======================================
Hits 2541 2541
Misses 189 189
Partials 59 59
Continue to review full report at Codecov.
|
|
for reference #3415: same behaviour with this change (local tests, Catalina) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard events in modal and autoclose handling use 'keydown' instead of 'keyup'
Fixes #3439
Unfortunately no way of adding e2e tests for this case