fix(pagination): disallow tab focus on disabled pagination #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
requested changes
Nov 15, 2019
There was a problem hiding this comment.
Hey @Smoggy,
thanks for the PR, LGTM.
The CI failed because the code is not properly formatted. Please check this → https://travis-ci.org/ng-bootstrap/ng-bootstrap/builds/612366140#L249
You could run yarn ci or at least yarn test locally on your machine to check that everything is fine before opening a PR in future.
Smoggy
force-pushed
the
pagination_disabled_focus_fix
branch
from
8b407ad
to
2e7aaa8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3468 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 96 96
Lines 2800 2800
Branches 516 516
=======================================
Hits 2552 2552
Misses 190 190
Partials 58 58
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR i to fix focus on disabled pagination control using TAB key