New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pagination): aria-current
attribute support
#3470
feat(pagination): aria-current
attribute support
#3470
Conversation
This commit adds support for aria-current attribute as per: https://getbootstrap.com/docs/4.3/components/pagination/#disabled-and-active-states https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook/Pagination
c689d82
to
7d2be43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Will merge when Travis is green
By the way just found out while looking at examples that we're also missing aria-disabled
attributes on <a>
links → https://getbootstrap.com/docs/4.3/components/pagination/#disabled-and-active-states
If you're motivated :)
Codecov Report
@@ Coverage Diff @@
## master #3470 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 96 96
Lines 2800 2800
Branches 516 516
=======================================
Hits 2552 2552
Misses 190 190
Partials 58 58
Continue to review full report at Codecov.
|
@peterblazejewicz Keeping It is necessary to remove |
This commit adds support for aria-current attribute as per:
https://getbootstrap.com/docs/4.3/components/pagination/#disabled-and-active-states
https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook/Pagination
Thanks!