Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): correct zindex of month selects #3473

Merged

Conversation

peterblazejewicz
Copy link
Contributor

This is a minor change that corrects rendering of the focus outline of
the custom select used for month selection.

Before:
Screenshot 2019-11-16 at 23 20 51
After:
Screenshot 2019-11-16 at 23 21 02

Minor z-index change is used to correct rendering as BS' docs outlines in the closing paragraph:
https://getbootstrap.com/docs/4.3/layout/overview/#z-index

Thanks!

This is a minor change that corrects rendering of the focus outline of
the custom select used for month selection.
@codecov-io
Copy link

Codecov Report

Merging #3473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3473   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          96       96           
  Lines        2800     2800           
  Branches      516      516           
=======================================
  Hits         2552     2552           
  Misses        190      190           
  Partials       58       58
Flag Coverage Δ
#e2e 56.21% <ø> (ø) ⬆️
#unit 87.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c502341...935d84f. Read the comment docs.

@maxokorokov maxokorokov added this to the 5.2.0 milestone Nov 18, 2019
@maxokorokov maxokorokov merged commit 6573b0d into ng-bootstrap:master Nov 18, 2019
@peterblazejewicz peterblazejewicz deleted the fix/month-view-focus branch November 18, 2019 21:07
@maxokorokov maxokorokov modified the milestones: 5.2.0, 5.1.5 Jan 3, 2020
maxokorokov pushed a commit that referenced this pull request Jan 7, 2020
This is a minor change that corrects rendering of the focus outline of
the custom select used for month selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants