Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(datepicker): Day focus doesn't work if more than 1 datepicker in same page #3494

Closed
gpolychronis opened this issue Nov 29, 2019 · 1 comment
Closed

bug(datepicker): Day focus doesn't work if more than 1 datepicker in same page #3494

gpolychronis opened this issue Nov 29, 2019 · 1 comment
Labels
component: datepicker type: bug
Milestone
5.2.2

Comments

@gpolychronis
Copy link
Contributor

gpolychronis commented Nov 29, 2019 •
edited

Bug description:

In a page that contains more than one datepicker instances (i.e. https://ng-bootstrap.github.io/#/components/datepicker/examples):

  • Tap on a day on one datepicker (i.e. on "Basic datepicker" example).
  • Check with keyboard that focusing a day works properly (i.e. press left arrow key).
  • Tap on a day on the other datepicker (i.e. on "Multiple months" example).
  • Check with keyboard that focusing day doesn't work (i.e. press left arrow key).
gpolychronis pushed a commit to gpolychronis/ng-bootstrap that referenced this issue Dec 4, 2019
fix(datepicker): focus on multiple instances (ng-bootstrap#3494)
437a526
@gpolychronis
Copy link
Contributor Author

@maxokorokov
@benouat
Please review

peterblazejewicz added a commit to peterblazejewicz/ng-bootstrap that referenced this issue Jan 6, 2020
@peterblazejewicz
fix(datepicker): refine focus state checks
2a90c88 
This adds additional condition to restrict focus in/out to instance of
the datepicker by verifyng if focus event target and related targets are
descendants of the datepicker element. This removes false results based
only on the class name checks, which fail when focus is switched between
datepicker instances.

Closes ng-bootstrap#3494
@peterblazejewicz peterblazejewicz mentioned this issue Jan 6, 2020
Closed
2 tasks
gpolychronis pushed a commit to gpolychronis/ng-bootstrap that referenced this issue Jan 23, 2020
@peterblazejewicz
fix(datepicker): refine focus state checks
27da357 
This adds additional condition to restrict focus in/out to instance of
the datepicker by verifyng if focus event target and related targets are
descendants of the datepicker element. This removes false results based
only on the class name checks, which fail when focus is switched between
datepicker instances.

Closes ng-bootstrap#3494
gpolychronis pushed a commit to gpolychronis/ng-bootstrap that referenced this issue Jan 23, 2020
@peterblazejewicz
fix(datepicker): refine focus state checks
18e84c8 
This adds additional condition to restrict focus in/out to instance of
the datepicker by verifyng if focus event target and related targets are
descendants of the datepicker element. This removes false results based
only on the class name checks, which fail when focus is switched between
datepicker instances.

Closes ng-bootstrap#3494
@maxokorokov maxokorokov added this to the 5.2.2 milestone Jan 28, 2020
gpolychronis pushed a commit to gpolychronis/ng-bootstrap that referenced this issue Jan 28, 2020
@peterblazejewicz
fix(datepicker): refine focus state checks
629df9b 
This adds additional condition to restrict focus in/out to instance of
the datepicker by verifyng if focus event target and related targets are
descendants of the datepicker element. This removes false results based
only on the class name checks, which fail when focus is switched between
datepicker instances.

Closes ng-bootstrap#3494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: datepicker type: bug
Projects
None yet
Milestone
5.2.2
Development

Successfully merging a pull request may close this issue.

fix(datepicker): refine focus state checks peterblazejewicz/ng-bootstrap
2 participants
@maxokorokov @gpolychronis