Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic change of minDate and maxDate doesn't reflect on DatePicker popover #3506

Closed
arvindm95 opened this issue Dec 6, 2019 · 0 comments · Fixed by #3507
Closed

Dynamic change of minDate and maxDate doesn't reflect on DatePicker popover #3506

arvindm95 opened this issue Dec 6, 2019 · 0 comments · Fixed by #3507
Labels
component: datepicker type: bug
Milestone
5.2.2

Comments

@arvindm95
Copy link
Contributor

arvindm95 commented Dec 6, 2019 •
edited

Bug description:

When datepicker is used in a popup, then dynamic changes to minDate and maxDate values doesn't reflect on the popup. But it works when the popup is closed and opened again.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-zpsmfq

  1. Click on the toggle button as soon as the page loads.
  2. After 5 seconds, notice the maxDate/minDate change in the Datepicker on the right, but not in the one on the left side of the page.
  3. Close the toggle and open again, maxDate/minDate will be reflected now.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 8.2.4

ng-bootstrap: 5.1.4

Bootstrap: 4.3.1
arvindm95 pushed a commit to arvindm95/ng-bootstrap that referenced this issue Dec 6, 2019
@Arvind-Muthuraman-Coda
fix(datepicker): reflect changes on popover when minDate, maxDate val…
3e5a391 
…ues change dynamically (ng-bootstrap#3506)

Fixes: ng-bootstrap#3506
@arvindm95 arvindm95 mentioned this issue Dec 6, 2019
Merged
5 tasks
maxokorokov pushed a commit that referenced this issue Jan 27, 2020
@arvindm95 @maxokorokov
fix(datepicker): update minDate and maxDate dynamically (#3507)
4f61496 
Propagate minDate and maxDate changes dynamically from the input datepicker to the datepicker

Fixes: #3506
@maxokorokov maxokorokov added this to the 5.2.2 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: datepicker type: bug
Projects
None yet
Milestone
5.2.2
Development

Successfully merging a pull request may close this issue.

fix(datepicker): reflect changes on popover when minDate, maxDate val… arvindm95/ng-bootstrap
2 participants
@maxokorokov @arvindm95