New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): reflect changes on popover when minDate, maxDate val… #3507
Conversation
…ues change dynamically (ng-bootstrap#3506) Fixes: ng-bootstrap#3506
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
==========================================
- Coverage 91.42% 91.41% -0.01%
==========================================
Files 96 96
Lines 2809 2806 -3
Branches 518 520 +2
==========================================
- Hits 2568 2565 -3
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please merge if this is fine? @peterblazejewicz |
I can't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
thanks for contributing and sorry for the delay!
…ues change dynamically (#3506)
Fixes: #3506
Before submitting a pull request, please make sure you have at least performed the following: