Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): reflect changes on popover when minDate, maxDate val… #3507

Merged
merged 2 commits into from Jan 27, 2020

Conversation

arvindm95
Copy link
Contributor

…ues change dynamically (#3506)

Fixes: #3506

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #3507 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   91.42%   91.41%   -0.01%     
==========================================
  Files          96       96              
  Lines        2809     2806       -3     
  Branches      518      520       +2     
==========================================
- Hits         2568     2565       -3     
  Misses        183      183              
  Partials       58       58
Flag Coverage Δ
#e2e 56.34% <0%> (-0.41%) ⬇️
#unit 88.26% <100%> (+0.09%) ⬆️
Impacted Files Coverage Δ
src/datepicker/datepicker-input.ts 96.52% <100%> (+0.15%) ⬆️
src/modal/modal-window.ts 91.66% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a4fba...4a9fa32. Read the comment docs.

Copy link
Contributor

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindm95
Copy link
Contributor Author

LGTM

Can you please merge if this is fine? @peterblazejewicz

@peterblazejewicz
Copy link
Contributor

I can't
/cc @maxokorokov

@maxokorokov maxokorokov modified the milestones: 5.2.1, 5.2.2 Jan 21, 2020
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

thanks for contributing and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic change of minDate and maxDate doesn't reflect on DatePicker popover
5 participants