Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(modal): add typing for modalRef.componentInstance (#2815) #3529

Merged

Conversation

maxokorokov
Copy link
Member

This reverts commit f450a7c

Fixes #3464

@maxokorokov maxokorokov added this to the 5.1.5 milestone Jan 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #3529 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3529   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          96       96           
  Lines        2800     2800           
  Branches      517      517           
=======================================
  Hits         2559     2559           
  Misses        183      183           
  Partials       58       58
Flag Coverage Δ
#e2e 56.46% <100%> (ø) ⬆️
#unit 88.24% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/modal/modal-ref.ts 100% <ø> (ø) ⬆️
src/modal/modal.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d457ef7...11900ea. Read the comment docs.

@maxokorokov maxokorokov merged commit 736953a into ng-bootstrap:master Jan 3, 2020
maxokorokov added a commit that referenced this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version is not compatible with noImplicitAny
2 participants