fix(modal): prevent modal from closing when using scrollbar #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3531 +/- ##
==========================================
+ Coverage 91.39% 91.41% +0.02%
==========================================
Files 96 96
Lines 2800 2807 +7
Branches 517 518 +1
==========================================
+ Hits 2559 2566 +7
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
peterblazejewicz
approved these changes
Jan 6, 2020
maxokorokov
force-pushed
the
modal/fix/scrollbar-click
branch
from
b0af2e5
to
6635ecb
Compare
benouat
requested changes
Jan 7, 2020
maxokorokov
force-pushed
the
modal/fix/scrollbar-click
branch
from
6635ecb
to
8bdb515
Compare
|
@maxokorokov when CI is ok, let's merge it 🚀 |
maxokorokov
added a commit
that referenced
this pull request
Jan 7, 2020
Using `mousedown` - `mouseup` - `click` combination to handle closing correctly. Fixes #3518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to use
mousedown-mouseup-clickto handle closing correctly:clickfixes the Modals dismissed by mouse release when trying to scroll the window #3518mousedown-mouseupfixes closing on accidental drags from modal dialog → backdropFixes #3518