feat(datepicker): add 'restoreFocus' input #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3539 +/- ##
==========================================
+ Coverage 91.59% 91.65% +0.05%
==========================================
Files 100 100
Lines 2868 2876 +8
Branches 527 529 +2
==========================================
+ Hits 2627 2636 +9
Misses 183 183
+ Partials 58 57 -1
Continue to review full report at Codecov.
|
|
How one could just disable focus behaviour? <input ngbDatepicker [restoreFocus]="false" [startDate]="{year: 2018, month: 3}"/>
<input ngbDatepicker restoreFocus="false" [startDate]="{year: 2018, month: 3}"/>(original use-case). Would that be supported? |
|
@peterblazejewicz this is intentional to force focus something, as focus should not be lost. Though you can always do:
UPDATE: I'll add a more specific test case for body focusing |
maxokorokov
force-pushed
the
feat/datepicker/refocus-strategy
branch
2 times, most recently
from
5397c7e
to
ca4faff
Compare
fbasso
reviewed
Jan 10, 2020
…t datepicker. ```ts @input() restoreFocus: true | string | HTMLElement; // defaults to true ``` By default it re-focuses element focused at the moment of datepicker opening. Otherwise accepts either selector or element reference. Fixes ng-bootstrap#3483
maxokorokov
force-pushed
the
feat/datepicker/refocus-strategy
branch
from
ca4faff
to
44955f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restoreFocusinput will define re-focusing strategy when closing the input datepicker.By default it re-focuses element focused at the moment of datepicker opening.
Otherwise accepts either selector or element reference.
Fixes #3483