Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav): allow importing 'NgbNavModule' independently #3554

Merged

Conversation

maxokorokov
Copy link
Member

Closes #3553

@maxokorokov maxokorokov added this to the 5.2.1 milestone Jan 22, 2020
@maxokorokov maxokorokov changed the title fix(nav) allow importing 'NgbNavModule' independently fix(nav): allow importing 'NgbNavModule' independently Jan 22, 2020
@maxokorokov maxokorokov assigned benouat and unassigned benouat Jan 22, 2020
@maxokorokov
Copy link
Member Author

@benouat could you PTAL? and I'll do the 5.2.1 afterwards

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #3554 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3554   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         100      100           
  Lines        2876     2876           
  Branches      529      529           
=======================================
  Hits         2636     2636           
  Misses        183      183           
  Partials       57       57
Flag Coverage Δ
#e2e 56.39% <ø> (ø) ⬆️
#unit 88.48% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cd798...f79c0b8. Read the comment docs.

@maxokorokov maxokorokov merged commit f808af3 into ng-bootstrap:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgbNav module is not exported
3 participants