feat(accordion): add custom class on card level #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
requested changes
Jan 29, 2020
There was a problem hiding this comment.
Hey, 2 things here:
-
Div's don't have disabled attribute, so the markup will be invalid → https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/disabled
-
Tests are missing
We should probably explore the way of adding a custom css class (as it is done, for example for modals and tooltips)
gpolychronis
force-pushed
the
feature/2262
branch
from
569592d
to
ff05200
Compare
Codecov Report
@@ Coverage Diff @@
## master #3563 +/- ##
==========================================
+ Coverage 91.67% 91.67% +<.01%
==========================================
Files 100 100
Lines 2883 2884 +1
Branches 532 532
==========================================
+ Hits 2643 2644 +1
Misses 183 183
Partials 57 57
Continue to review full report at Codecov.
|
gpolychronis
changed the title
gpolychronis
force-pushed
the
feature/2262
branch
from
ff05200
to
8aa1564
Compare
benouat
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable customization of accordion panel conditionally according to being disabled or not.
Fixes #2262