Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavChangeEvent is raised if activeId is not set #3564

Closed
ghost opened this issue Jan 27, 2020 · 1 comment · Fixed by #3567
Closed

NavChangeEvent is raised if activeId is not set #3564

ghost opened this issue Jan 27, 2020 · 1 comment · Fixed by #3567
Labels
component: nav type: bug
Milestone
5.2.2

Comments

@ghost
Copy link

ghost commented Jan 27, 2020

Bug description:

https://ng-bootstrap.github.io/#/components/nav/api#NgbNavChangeEvent

The payload of the change event emitted right before the nav change happens on user click.
This event won't be emitted if nav is changed programmatically via [activeId] or .select().

But if I don't set the initial activeId, the event is emitted after plugin selects the first tab for me

image

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-qqykku?file=app/nav-basic.html
@maxokorokov maxokorokov added this to the 5.2.2 milestone Jan 27, 2020
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 27, 2020
@maxokorokov
fix(nav): don't emit (navChange) when activeId is not set initially
3b69475 
Fixes ng-bootstrap#3564
@maxokorokov maxokorokov mentioned this issue Jan 27, 2020
Merged
@maxokorokov
Copy link
Member

@nseni yep, thanks for this. This is the omitted use case due to the late refactoring before releasing navs... Should be fixed in 5.2.2

benouat pushed a commit that referenced this issue Feb 7, 2020
@maxokorokov
fix(nav): don't emit (navChange) when activeId is not set initially (#…
dd1c35d 
…3567)

Fixes #3564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: nav type: bug
Projects
None yet
Milestone
5.2.2
Development

Successfully merging a pull request may close this issue.

fix(nav): don't emit '(navChange)' when 'activeId' is not set initially maxokorokov/ng-bootstrap
1 participant
@maxokorokov