fix(datepicker): handle multiple input changes once #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously internally calling
```ts
service.minDate = ...;
service.maxDate = ...;
```
resulted in two observable emissions, one per input change.
Now the API is changed to:
```ts
service.set({minDate: ..., maxDate: ...})
```
which results in a single emission for any number of inputs changed at the same time.
Fixes ng-bootstrap#3545
maxokorokov
force-pushed
the
datepicker/fix/min-max-dates-in-future
branch
from
c331cb0
to
bb03aab
Compare
Codecov Report
@@ Coverage Diff @@
## master #3565 +/- ##
=========================================
+ Coverage 91.67% 91.7% +0.02%
=========================================
Files 100 100
Lines 2882 2892 +10
Branches 532 533 +1
=========================================
+ Hits 2642 2652 +10
Misses 183 183
Partials 57 57
Continue to review full report at Codecov.
|
benouat
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously internally calling
resulted in two observable emissions, one per input change.
Now the API is changed to:
which results in a single emission for any number of inputs changed at the same time.
Fixes #3545