Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav): don't emit '(navChange)' when 'activeId' is not set initially #3567

Conversation

maxokorokov
Copy link
Member

Fixes #3564

@codecov-io
Copy link

Codecov Report

Merging #3567 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3567   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         100      100           
  Lines        2882     2882           
  Branches      532      532           
=======================================
  Hits         2642     2642           
  Misses        183      183           
  Partials       57       57
Flag Coverage Δ
#e2e 56.28% <0%> (ø) ⬆️
#unit 88.5% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/nav/nav.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f61496...3b69475. Read the comment docs.

@benouat benouat merged commit dd1c35d into ng-bootstrap:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavChangeEvent is raised if activeId is not set
3 participants