Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use 0 as nav id #3569

Closed
ghost opened this issue Jan 28, 2020 · 1 comment · Fixed by #3571
Closed

Can't use 0 as nav id #3569

ghost opened this issue Jan 28, 2020 · 1 comment · Fixed by #3571
Labels
component: nav type: bug
Milestone
5.2.2

Comments

@ghost
Copy link

ghost commented Jan 28, 2020

Bug description:

<li [ngbNavItem]="0">

In this case the plugin thinks there's no id and assigns internal ID (ngb-nav-0) instead.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-adgxbn?file=app/nav-basic.html
@maxokorokov maxokorokov added this to the 5.2.2 milestone Jan 29, 2020
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 29, 2020
@maxokorokov
fix(nav): allow having falsy values like 0 and 'false' for nav ids
8adb845 
Fixes ng-bootstrap#3569
@maxokorokov maxokorokov mentioned this issue Jan 29, 2020
Merged
@maxokorokov
Copy link
Member

Thanks, also should be the part of 5.2.2

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Feb 7, 2020
@maxokorokov
fix(nav): allow having falsy values like 0 and 'false' for nav ids
e432968 
Fixes ng-bootstrap#3569
maxokorokov added a commit that referenced this issue Feb 7, 2020
@maxokorokov
fix(nav): allow having falsy values like 0 and 'false' for nav ids (#…
686fbd5 
…3571)

Fixes #3569
@Clashsoft Clashsoft mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: nav type: bug
Projects
None yet
Milestone
5.2.2
Development

Successfully merging a pull request may close this issue.

fix(nav): allow having falsy values like 0 and 'false' for nav ids maxokorokov/ng-bootstrap
1 participant
@maxokorokov