Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NgbDropdownItem breaks activating a button with Enter/Space #3570

Closed
ghost opened this issue Jan 28, 2020 · 2 comments · Fixed by #3573
Closed

NgbDropdownItem breaks activating a button with Enter/Space #3570

ghost opened this issue Jan 28, 2020 · 2 comments · Fixed by #3573
Labels
component: dropdown type: bug
Milestone
5.2.2

Comments

@ghost
Copy link

ghost commented Jan 28, 2020

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-prjmrz?file=app/dropdown-basic.html

Bug description:

When NgbDropdownItem is applied, Enter or Space don't trigger (click) handler.

  1. Use Tab to select first dropdown
  2. Press Enter to open dropdown
  3. Navigate to any dropdown item using arrow keys
  4. Press Enter or Space. Nothing happens
  1. Use Tab to select second dropdown
  2. Press Enter to open dropdown
  3. Navigate to any dropdown item using Tab key
  4. Press Enter or Space. Function assigned to (click) handler is executed.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 8.2.4
ng-bootstrap: 5.2.1
Browser: Google Chrome
@maxokorokov
Copy link
Member

Related to #3561 I guess

@maxokorokov
Copy link
Member

Looks like for this particular case we still need to close the popup asynchronously using either requestAntimationFrame or setTimeout

@maxokorokov maxokorokov added this to the 5.2.2 milestone Jan 29, 2020
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Feb 3, 2020
@maxokorokov
fix(dropdown): execute user (click) handlers on Enter and Space
56b7129 
Fixes ng-bootstrap#3570
@maxokorokov maxokorokov mentioned this issue Feb 3, 2020
Merged
benouat pushed a commit that referenced this issue Feb 7, 2020
@maxokorokov
fix(dropdown): execute user (click) handlers on Enter and Space (#3573)
f845951 
Fixes #3570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dropdown type: bug
Projects
None yet
Milestone
5.2.2
Development

Successfully merging a pull request may close this issue.

fix(dropdown): execute user (click) handlers on Enter and Space maxokorokov/ng-bootstrap
1 participant
@maxokorokov