Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav): allow having falsy values like 0 and 'false' for nav ids #3571

Merged

Conversation

maxokorokov
Copy link
Member

Fixes #3569

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #3571 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3571      +/-   ##
==========================================
+ Coverage    91.7%   91.71%   +<.01%     
==========================================
  Files         100      100              
  Lines        2895     2896       +1     
  Branches      533      533              
==========================================
+ Hits         2655     2656       +1     
  Misses        183      183              
  Partials       57       57
Flag Coverage Δ
#e2e 56.59% <0%> (-0.02%) ⬇️
#unit 88.49% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/nav/nav.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f626e1...e432968. Read the comment docs.

@maxokorokov maxokorokov merged commit 686fbd5 into ng-bootstrap:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use 0 as nav id
3 participants