Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): pass an HTMLElement to modal container option (#3584) #3585

Merged

Conversation

drobins29
Copy link
Contributor

@drobins29 drobins29 commented Feb 12, 2020

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Fixes #3584

src/util/util.ts Outdated Show resolved Hide resolved
@drobins29 drobins29 changed the title fix(modal): pass an HTMLElement to modal container option (#3584) feat(modal): pass an HTMLElement to modal container option (#3584) Feb 12, 2020
@maxokorokov maxokorokov added this to the 5.3.0 milestone Feb 13, 2020
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxokorokov maxokorokov merged commit 3c65b21 into ng-bootstrap:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgbModalStack doesn't support container selector existing within a shadowdom
3 participants