Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): prevent autoclose with default triggers on iPadOS 13 #3593

Merged
merged 1 commit into from Feb 14, 2020

Conversation

maxokorokov
Copy link
Member

Same as #3582, but for the iPadOS 13

Fixes #3591

@maxokorokov maxokorokov added this to the 5.3.0 milestone Feb 14, 2020
@maxokorokov
Copy link
Member Author

Tested on the iPad Pro simulator with iOS 13.3

@codecov-io
Copy link

Codecov Report

Merging #3593 into master will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3593      +/-   ##
==========================================
- Coverage   91.71%   91.68%   -0.03%     
==========================================
  Files         100      100              
  Lines        2898     2900       +2     
  Branches      535      535              
==========================================
+ Hits         2658     2659       +1     
  Misses        183      183              
- Partials       57       58       +1
Flag Coverage Δ
#e2e 56.55% <40%> (-0.01%) ⬇️
#unit 88.47% <40%> (-0.03%) ⬇️
Impacted Files Coverage Δ
src/util/autoclose.ts 88.46% <40%> (-3.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc4ceb...2621354. Read the comment docs.

@maxokorokov maxokorokov merged commit b8874ad into ng-bootstrap:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoclose broken on iPad with iOS 13
2 participants