ngb-timepicker - Manuel entering time values into input fields doesn't work on Ms-Edge 16-18

[brabenetz]

Microsoft Edge 44.17763.831.0
Microsoft EdgeHTML 18.17763

This can be reproduced on every example of the ng-bootstrap example-page:
https://ng-bootstrap.github.io/#/components/timepicker/examples

I tested following ng-bootstrap versions
✓ 4.1.1
✓ 4.2.2
- 5.0.0 ( compile errors: Couldn't resolve original symbol for ./datepicker/adapters/ngb-date-adapter ...)
✓ 5.1.0
✓ 5.1.5
X 5.2.0
X 5.2.1
X 5.2.3
- 6.0.0 ( compile errors (e.g.: error TS1086: An accessor cannot be declared in an ambient context.)

In other words:
It worked until Version 5.1.5 also in MS Edge 18.
Since version 5.2.0 it is broken.
6.0.0 I couldn't test because of breaking changes.

I also tested https://ng-bootstrap.github.io/#/components/timepicker/examples on multiple Ms Edge Browsers:
X EdgeHTML 18
X EdgeHTML 17
X EdgeHTML 16
✓ EdgeHTML 15

Since Ms-Edge version 16 (before Chromium) the current ng-bootstrap timepicker doesn't work anymore. It worked with EdgeHTML version 15.

[maxokorokov]

@brabenetz could you please clarify what exactly is not working / record a gif or video maybe?

I can change time values without any issues in Edge 17

[brabenetz]

Just enter a new Value with the Keyboard:

[maxokorokov]

Oh this... let's say it is done "by design", because the model is updated only on blur... and it is not related to any specific browser

Please reopen if necessary.

[brabenetz]

That's exactly what dos NOT work with MS-Edge 18!

[maxokorokov]

X EdgeHTML 18
X EdgeHTML 17
X EdgeHTML 16
✓ EdgeHTML 15

Since Ms-Edge version 16

@brabenetz you also told it was not working with Edge 17, but it actually is. At least I couldn't reproduce it in Edge 17 on Windows 10.

My bad! I was checking it in the IE11 Window... sorry @brabenetz :)

[maxokorokov]

Managed to reproduce in SauceLabs in Edge 18 on the demo site.

Looking at the history it might be related to this change → #3247
Similar issues in Angular repo → angular/angular#34035

cc @fbasso

---

✓ 5.1.5
X 5.2.0

@brabenetz, this was helpful, thanks for checking multiple versions

UPDATE: reverting #3247 fixes the issue, @fbasso could you PTAL ?

[benouat]

Closing for 2 reasons:

• reverting feat(timepicker): input filter to accept only numbers #3247 performed seems to have fixed the issue (See previous @maxokorokov comment)
• I am not that sure we do support old version of Edge, now that the Chromium version has landed.

[pmairoldi]

@benouat Just letting you know that this is still broken on Edge 18. What's the official stance on which browsers are supported?

[songokudbz]

Edge on MAC is working but Edge on Windows is not working...