Regression: modal components don't have the correct injector

[jnizet]

Bug description:

Since version 14, a component used as the modal content doesn't have the correct injector anymore.

If a lazy loaded module defines a provider for a service and a component from that module is used as a modal content and tries to get the service via DI, a NullInjectorError is thrown when opening the modal.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/github/jnizet/modal-repro/tree/ngb14

This repro is also available on github: https://github.com/jnizet/modal-repro

The main branch shows the code working with ng-bootstrap 13, and the ngb14 branch shows the same code not working with ng-bootstrap 14.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 15.0.4

ng-bootstrap: 14.0.0

Bootstrap: 5.2.3

[stefanwaldhauser]

I have the same problem. Does somebody know of a hotfix for this problem?

[krusche]

We have the same problem and would appreciate a fix

[egdw-nipra]

This really needs more attention. v.14.0.0 is currently completely broken for anyone using lazy loaded modules.

[maxokorokov]

Indeed, I think I've screwed up two things:

1. Modal content creation

ng-bootstrap/src/modal/modal-stack.ts

Lines 234 to 241 in 7f2146d

	const elementInjector = Injector.create({
	providers: [{ provide: NgbActiveModal, useValue: context }],
	parent: contentInjector,
	});
	const componentRef = createComponent(componentType, {
	environmentInjector: this._applicationRef.injector,
	elementInjector,
	});

I think environmentInjector should be contentInjector.get(EnvironmentInjector, null) || this._applicationRef.injector.

2. NgbModalModule

ng-bootstrap/src/modal/modal.module.ts

Lines 8 to 9 in 7f2146d

	@NgModule({})
	export class NgbModalModule {}

It should provide NgbModal, so @NgModule({providers: [NgbModal]})

I'll open a PR ASAP

[jnizet]

If NgbModal needs to be provided by NgbModalModule for this bug to be fixed, does it mean that standalone components should have it in their providers if they don't import the NgbModalModule? If so, it would be worth documenting it.

[jcalijurio]

I have the same problem here too.

[maxokorokov]

@jnizet I've opened the PR
I think we should simply provide NgbModal both in NgbModalModule and in 'root'. I didn't manage to reproduce this issue with standalone components

[jnizet]

Thanks for the fix and for the release @maxokorokov. Works fine here.